Repository navigation
ci(guard): stop the rust and parity jobs from timing out on a slow runner - #497
Merged
Merged
Conversation
… span The docs site prints a code span as written, so a table cell that escapes a pipe for GitHub shows the reader a backslash, and the copied command breaks. The check finds every such row under docs/ and proves itself on planted pages. Bead: K013 Bead: K020
…opy and run as written The docs site printed the backslash of each escaped pipe inside a table code span, so the copied command was broken. The Nextflow row of Getting started points at the install command in Full run, the FAQ's BAM build check and the site table hash of Keeping versions up to date move into code blocks under their tables, and the cn-loci readings row names its separator in words. Bead: K013 Bead: K020
ShellCheck read the single-quoted printf as a missed expansion. Bead: K013
… when opened The privacy page left the CPSR (step 17) and MultiQC (step 28) reports as "not checked", so a reader could not tell whether opening them tells a server their IP address. Both were opened in a browser that blocked and logged every request to the internet: neither loads anything. Their external addresses are plain links. Bead: K010 Bead: K028
…hors A cargo test in og-dev reads docs/stylesheets/theme.css and zensical.toml. It fails when the accent a colour scheme ends up with is below 4.5:1 on the active menu item's tint, and when anchor_linenums is on. Both fail on main: 3.12:1 dark, 4.49:1 light, and the flag. Bead: S08 Bead: S10
The side menu paints the current page in the accent, #2563eb for both schemes, on the accent's 10% tint. That is 3.1:1 on the dark page and 4.49:1 on the light one. The accent now takes #60a5fa on slate (6.3:1) and #1d4ed8 on default (5.8:1), the colours links already use. The transparent accent and the card hover border stay. Bead: S08
anchor_linenums gave every code line an empty link with no name that takes a Tab stop: 122 on getting-started, 88 pages in all. The site shows no line numbers and no page links to these anchors. Highlighting and the copy button do not change. Bead: S10
# Conflicts: # CHANGELOG.md
…ivacy # Conflicts: # CHANGELOG.md
The dark accent #60a5fa took Zensical's white --md-accent-bg-color text on the Back to top and side menu buttons at 2.5:1. That text now takes the page colour, 6.9:1, and the docs theme test checks text on the accent in both schemes.
…trast-anchors # Conflicts: # CHANGELOG.md
… test misses both reports
… an empty site table hash
The rust job took 23 minutes on main (limit 30) and parity 19 (limit 20). The same trees on the geiresx fork ran past both limits, twice, so a docs-only PR (GeiserX#494) could not get a green ci-ok. Raise rust to 45 and parity to 35: the limit is there to stop a hung job, not a slow one.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A docs-only pull request (#494) could not get a green
ci-ok. The Guardrustandparityjobs hit their time limits on the geiresx fork, twice. The time limit is there to stop a job that hangs. These jobs were slow, not hung.The same jobs already run close to their limits on main. In the Guard run on main at 2207350 (https://github.com/GeiserX/OwnGenome/actions/runs/44323123387),
rusttook 23 minutes against a limit of 30, andparitytook 19 against a limit of 20. On the fork (https://github.com/geiresx/OwnGenome/actions/runs/44307670884), both jobs were cancelled at 30 and 20 minutes.The fix raises
rustto 45 minutes andparityto 35, and updates the comments above both jobs with the measured times. No step changes.How it was checked: the change is two numbers and two comments in
.github/workflows/guard.yml. Guard runs on this branch with the new limits.